Add and correct 26.1 protocol and registry mappings#1169
Closed
Mikulasz12 wants to merge 3 commits intoPrismarineJS:masterfrom
Closed
Add and correct 26.1 protocol and registry mappings#1169Mikulasz12 wants to merge 3 commits intoPrismarineJS:masterfrom
Mikulasz12 wants to merge 3 commits intoPrismarineJS:masterfrom
Conversation
Mikulasz12
force-pushed
the
feature/26.1-compat
branch
from
763d515 to
2dbffbe
Compare
Mikulasz12
force-pushed
the
feature/26.1-compat
branch
from
2dbffbe to
ed54b1d
Compare
Member
|
Please open this PR against the |
Member
|
Data like blockCollisionShapes is supposed to come from minecraft-data-generator, should not need to manually modify them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the existing 26.1 data branch onto
masterand adds the follow-up fixes needed to make 26.1 decode.What changed
pc_26_1data work intomasterdataPathswiringblocksitemsblockCollisionShapesWhy
The initial 26.1 data branch was enough to get protocol and version support in place, but some 26.1 registry data had drifted.
In practice that meant clients could connect, but some ids decoded incorrectly. For example:
iron_barscame through ascopper_barssoul_lanterncame through ascopper_lanternblockAt()read a placedsoul_lanternascrimson_pressure_plateVerification
Tested with a Mineflayer bot using
version: "26.1"against a vanilla server.Checked that:
Examples verified:
iron_barssoul_lanternoak_planks